Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502646

[PATCH v5 12/23] usb: chipidea: msm: Mark device as runtime pm active

Show all headers | View raw

We're not properly marking the glue layer/wrapper device as
runtime active, so runtime PM believes that the hardware state is
inactive when we call pm_runtime_enable() in this driver. This
causes a problem when the glue layer has a power domain
associated with it, because runtime PM will go and disable the
power domain to match the 'inactive' state of the device. Let's
mark the device as active so that runtime PM doesn't improperly
power down this device when it's actually active.

Acked-by: Peter Chen <peter.chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
---
 drivers/usb/chipidea/ci_hdrc_msm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index 3889809fd0c4..89c1a02d69b5 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -80,6 +80,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, plat_ci);
 
+	pm_runtime_set_active(&pdev->dev);
 	pm_runtime_no_callbacks(&pdev->dev);
 	pm_runtime_enable(&pdev->dev);
 
-- 
2.10.0.297.gf6727b0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/23] Support qcom's HSIC USB and rewrite USB2 HS support Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 12/23] usb: chipidea: msm: Mark device as runtime pm active Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 05/23] usb: chipidea: Handle extcon events properly Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 04/23] usb: chipidea: Only read/write OTGSC from one place Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 10/23] usb: chipidea: Consolidate extcon notifiers Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 15/23] usb: chipidea: msm: Add proper clk and reset support Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 14/23] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 13/23] usb: chipidea: msm: Rely on core to override AHBBURST Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 03/23] usb: ulpi: Support device discovery via DT Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
    Re: [PATCH v5 03/23] usb: ulpi: Support device discovery via DT Rob Herring <robh@kernel.org> - 2016-10-18 18:50 +0200
  [PATCH v5 16/23] usb: chipidea: msm: Mux over secondary phy at the right time Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
  [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-18 04:10 +0200
    Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable  path Peter Chen <hzpeterchen@gmail.com> - 2016-10-19 03:20 +0200
      Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable  path Peter Chen <hzpeterchen@gmail.com> - 2016-10-19 16:40 +0200
        Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable  path Peter Chen <hzpeterchen@gmail.com> - 2016-10-20 12:20 +0200
          Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable  path Peter Chen <hzpeterchen@gmail.com> - 2016-10-21 04:20 +0200
  Re: [PATCH v5 00/23] Support qcom's HSIC USB and rewrite USB2 HS  support Peter Chen <hzpeterchen@gmail.com> - 2016-10-18 11:40 +0200

csiph-web