Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502493
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 2/5] drm/fsl-dcu: do not transfer registers on plane init |
| Date | 2016-10-17 23:40 +0200 |
| Message-ID | <stnNw-Pb-25@gated-at.bofh.it> (permalink) |
| References | <stnNv-Pb-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
There is no need to explicitly initiate a register transfer and turn off the DCU after initializing the plane registers. In fact, this is harmful and leads to unnecessary flickers if the DCU has been left on by the bootloader. Signed-off-by: Stefan Agner <stefan@agner.ch> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c index a7e5486..9e6f7d8 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c @@ -211,11 +211,6 @@ void fsl_dcu_drm_init_planes(struct drm_device *dev) for (j = 1; j <= fsl_dev->soc->layer_regs; j++) regmap_write(fsl_dev->regmap, DCU_CTRLDESCLN(i, j), 0); } - regmap_update_bits(fsl_dev->regmap, DCU_DCU_MODE, - DCU_MODE_DCU_MODE_MASK, - DCU_MODE_DCU_MODE(DCU_MODE_OFF)); - regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE, - DCU_UPDATE_MODE_READREG); } struct drm_plane *fsl_dcu_drm_primary_create_plane(struct drm_device *dev) -- 2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 0/5] drm/fsl-dcu: initialization fixes Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
[PATCH v3 3/5] drm/fsl-dcu: do not transfer registers in mode_set_nofb Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
[PATCH v3 4/5] drm/fsl-dcu: enable pixel clock when enabling CRTC Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
[PATCH v3 5/5] drm/fsl-dcu: only init fbdev if required Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
Re: [PATCH v3 5/5] drm/fsl-dcu: only init fbdev if required Daniel Vetter <daniel@ffwll.ch> - 2016-10-18 09:50 +0200
Re: [PATCH v3 5/5] drm/fsl-dcu: only init fbdev if required Stefan Agner <stefan@agner.ch> - 2016-10-18 19:50 +0200
Re: [PATCH v3 5/5] drm/fsl-dcu: only init fbdev if required Daniel Vetter <daniel@ffwll.ch> - 2016-10-19 18:40 +0200
[PATCH v3 1/5] drm/fsl-dcu: enable TCON bypass mode by default Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
RE: [PATCH v3 1/5] drm/fsl-dcu: enable TCON bypass mode by default Meng Yi <meng.yi@nxp.com> - 2016-10-19 19:50 +0200
RE: [PATCH v3 1/5] drm/fsl-dcu: enable TCON bypass mode by default Stefan Agner <stefan@agner.ch> - 2016-10-20 02:10 +0200
[PATCH v3 2/5] drm/fsl-dcu: do not transfer registers on plane init Stefan Agner <stefan@agner.ch> - 2016-10-17 23:40 +0200
csiph-web