Re: [PATCH 11/12] jump_label: declare jump table as external array

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/12] jump_label: declare jump table as external array
Date	2016-10-17 23:40 +0200
Message-ID	<stnNv-Pb-11@gated-at.bofh.it> (permalink)
References	<ssVod-7uv-5@gated-at.bofh.it> <ssVod-7uv-19@gated-at.bofh.it> <ssWtY-8bF-11@gated-at.bofh.it> <ssWX1-8mi-69@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 16 Oct 2016 18:50:55 +0200
Vegard Nossum <vegard.nossum@oracle.com> wrote:
> >
> > NAK, -ENOCHANGELOG.

Agreed.

> >  
> 
> Hi Peter,
> 
> It's true I didn't put an RFC tag on this (mostly because git-send-email
> doesn't seem to have an option for it?), but the whole point of doing

I would think it does, although I never use it (I always use quilt
mail).


> these other patches (03-12) was to demonstrate what the patches would
> look like for some other kernel code and ask for feedback on the overall
> interface/approach. I don't know if you read the introduction and first
> patch in the series, but I'd expect that to be more than enough to
> understand the problem.

But we were not Cc'd on those. If we are not on the Cc to the
introduction nor the other patches, we will most likely not be reading
them.

> 
> If we really have to repeat the rationale for every patch, can we reuse
> this?
> 
> "Comparisons between pointers to different arrays is technically
> undefined behaviour and recent GCCs may incorrectly optimise away loop
> termination conditions. Use the external array accessor macros to
> prevent this from happening."
> 

So basically gcc will break on these array address calculations? Which
version of gcc started this, and has this actually been an issue?


-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 11/12] jump_label: declare jump table as external array Vegard Nossum <vegard.nossum@oracle.com> - 2016-10-16 17:20 +0200
  Re: [PATCH 11/12] jump_label: declare jump table as external array Peter Zijlstra <peterz@infradead.org> - 2016-10-16 18:30 +0200
    Re: [PATCH 11/12] jump_label: declare jump table as external array Vegard Nossum <vegard.nossum@oracle.com> - 2016-10-16 19:00 +0200
      Re: [PATCH 11/12] jump_label: declare jump table as external array Peter Zijlstra <peterz@infradead.org> - 2016-10-16 19:50 +0200
      Re: [PATCH 11/12] jump_label: declare jump table as external array Steven Rostedt <rostedt@goodmis.org> - 2016-10-17 23:40 +0200

csiph-web