Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502429

Re: [PATCH 2/5] staging/vchi: Fix build warnings when formatting pointers on aarch64.

Show all headers | View raw

On Mon, Oct 17, 2016 at 12:44:03PM -0700, Eric Anholt wrote:
> The code was generally using "%x" to print and "(unsigned int)" to
> cast the pointers, but we have %p for printing pointers in the same
> format without any broken casts.

I already did this work, it's all checked into my tree, and is in
linux-next now.  You were cc:ed on the patches as well.

Also, please use "%pK" for kernel pointers, you never want to print an
address to userspace unless debugging is enabled, as it is a security
leak.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] staging/vchi: Fix build warnings when formatting pointers on aarch64. Eric Anholt <eric@anholt.net> - 2016-10-17 21:50 +0200
  Re: [PATCH 2/5] staging/vchi: Fix build warnings when formatting  pointers on aarch64. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-17 22:30 +0200
    Re: [PATCH 2/5] staging/vchi: Fix build warnings when formatting pointers on aarch64. Eric Anholt <eric@anholt.net> - 2016-10-18 01:40 +0200
      Re: [PATCH 2/5] staging/vchi: Fix build warnings when formatting  pointers on aarch64. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-18 08:50 +0200

csiph-web