Re: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation

From	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation
Date	2016-10-17 21:20 +0200
Message-ID	<stlC1-7KA-13@gated-at.bofh.it> (permalink)
References	<stgM2-4uk-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ralf,

> On Oct 17, 2016, at 16:59 , Ralf Ramsauer <ralf@ramses-pyramidenbau.de> wrote:
> 
> Hi,
> 
> this one fixes initialisation of I2C/SPI nodes.  Upon failure during
> intialisation, nodes were erroneously populated and never unmarked.
> 
> This lead to the problem that re-loaded drivers will never probe those devices
> again and can easily be fixed by clearing the OF_POPULATE flag when the node
> doesn't successfully initialise.
> 
> For the discussion of v1, see
> https://lkml.org/lkml/2016/10/14/483
> 
>  Ralf
> 
> changes since v1:
>  - also fix I2C core driver
>  - keep the atomic test-and-set, as Geert suggested
> 
> Ralf Ramsauer (2):
>  spi: mark device nodes only in case of successful instantiation
>  i2c: mark device nodes only in case of successful instantiation
> 
> drivers/i2c/i2c-core.c | 11 ++++++++++-
> drivers/spi/spi.c      |  5 ++++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
> 
> -- 
> 2.10.1
> 

Thanks for catching this.

Acked-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-10-17 16:10 +0200
  [PATCH v2 2/2] i2c: mark device nodes only in case of successful instantiation Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-10-17 16:10 +0200
    Re: [PATCH v2 2/2] i2c: mark device nodes only in case of successful instantiation Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-17 16:20 +0200
      Re: [PATCH v2 2/2] i2c: mark device nodes only in case of successful  instantiation Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-10-17 16:40 +0200
    Re: [PATCH v2 2/2] i2c: mark device nodes only in case of successful instantiation Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-10-17 21:20 +0200
    Re: [PATCH v2 2/2] i2c: mark device nodes only in case of successful  instantiation Wolfram Sang <wsa@the-dreams.de> - 2016-10-25 11:30 +0200
  [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-10-17 16:10 +0200
    Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-17 16:20 +0200
    Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-10-17 21:20 +0200
    Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful  instantiation Mark Brown <broonie@kernel.org> - 2016-10-24 19:40 +0200
    Applied "spi: mark device nodes only in case of successful instantiation" to the spi tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:20 +0200
  Re: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-10-17 21:20 +0200

csiph-web