Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1502308

[PATCH] xfs: remove redundant assignment of ifp

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] xfs: remove redundant assignment of ifp
Date 2016-10-17 19:40 +0200
Message-ID <stk3g-6wD-27@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

Remove redundant ifp = ifp statement, it does nothing. Found with
static analysis by CoverityScan.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index c27344c..0283b7e 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
 	ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
 			&eidx, &got, &new);
 
-	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
+	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
 	ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
 		(uint)sizeof(xfs_bmbt_rec_t)));
 	ASSERT(del->br_blockcount > 0);
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] xfs: remove redundant assignment of ifp Colin King <colin.king@canonical.com> - 2016-10-17 19:40 +0200

csiph-web