Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502275

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

From Jakub Kicinski <kubakici@wp.pl>
Newsgroups linux.kernel
Subject Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage
Date 2016-10-17 19:10 +0200
Message-ID <stjAg-6l5-91@gated-at.bofh.it> (permalink)
References <spPfj-LZ-7@gated-at.bofh.it> <spPfj-LZ-5@gated-at.bofh.it> <stiXv-5Qr-11@gated-at.bofh.it> <stjqz-61C-77@gated-at.bofh.it> <stjAf-6l5-79@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 17 Oct 2016 18:00:27 +0100, Jakub Kicinski wrote:
> On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote:
> > From: Jakub Kicinski <kubakici@wp.pl>
> > Date: Mon, 17 Oct 2016 17:20:06 +0100
> >   
> > > Please correct me if I'm wrong but it seems like we are now limiting
> > > _all_ ethernet drivers to ETH_DATA_LEN in net-next.    
> > 
> > No, because the driver can increase the netdev->max_mtu value as needed.  
> 
> But since almost no driver is doing that, yet, right now in net-next
> jumbo frames are not possible, no?  I thought the idea was the leave
> the value at 0 so drivers can opt-in as needed but since setup_ether()
> is initializing to 1500 now all ethernet driver get a default of
> limiting to 1500.
> 
> IOW this patch made checks which were done only in eth_change_mtu()
> mandatory for all drivers.

all ethernet drivers to be clear

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jakub Kicinski <kubakici@wp.pl> - 2016-10-17 18:30 +0200
  Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage David Miller <davem@davemloft.net> - 2016-10-17 19:00 +0200
    Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jakub Kicinski <kubakici@wp.pl> - 2016-10-17 19:10 +0200
      Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jakub Kicinski <kubakici@wp.pl> - 2016-10-17 19:10 +0200
      Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage David Miller <davem@davemloft.net> - 2016-10-17 19:20 +0200
        Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage David Miller <davem@davemloft.net> - 2016-10-17 19:30 +0200
          Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jarod Wilson <jarod@redhat.com> - 2016-10-17 22:10 +0200
            Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jarod Wilson <jarod@redhat.com> - 2016-10-17 22:30 +0200
        Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove  usage Jakub Kicinski <kubakici@wp.pl> - 2016-10-17 19:30 +0200

csiph-web