Groups > linux.kernel > #1502093

Re: [patch ]mm/zs_malloc: Fix bit spinlock replacement

From	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [patch ]mm/zs_malloc: Fix bit spinlock replacement
Date	2016-10-17 17:20 +0200
Message-ID	<sthRL-59n-15@gated-at.bofh.it> (permalink)
References	<spcH2-6dt-141@gated-at.bofh.it> <ssK9r-62-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-10-16 05:18:03 [+0200], Mike Galbraith wrote:
> 
> Do not alter HANDLE_SIZE, memory corruption ensues.  The handle is
> a pointer, allocate space for the struct it points to and align it
> ZS_ALIGN.  Also, when accessing the struct, mask HANDLE_PIN_BIT.

So this is to merged / folded into "mm/zsmalloc: Use get/put_cpu_light
in zs_map_object()/zs_unmap_object()" which I re-did for v4.8?
How was this tested?
I have:
   CONFIG_FRONTSWAP=y
   # CONFIG_CMA is not set
   CONFIG_ZSWAP=y
   CONFIG_ZPOOL=y
   CONFIG_ZBUD=m
   CONFIG_Z3FOLD=m
   CONFIG_ZSMALLOC=m
   # CONFIG_PGTABLE_MAPPING is not set
   CONFIG_ZSMALLOC_STAT=y

and

   # cat /sys/module/zswap/parameters/enabled
   Y
   cat /sys/module/zswap/parameters/zpool
   zbud
   # cat /sys/module/zswap/parameters/compressor 
   lzo
   # cat /sys/module/zswap/parameters/max_pool_percent 
   20

and I do have 1GiB of swap on /dev/vdc. While I get swap to be used, I
see no firework. Is there something wrong with my setup? I would assume
so due to the lack of the fireworks on my side…

> Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>

Sebastian

Thread

[patch ]mm/zs_malloc: Fix bit spinlock replacement Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-10-16 05:20 +0200
  Re: [patch ]mm/zs_malloc: Fix bit spinlock replacement Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-10-17 17:20 +0200
    Re: [patch ]mm/zs_malloc: Fix bit spinlock replacement Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-10-17 18:20 +0200
  [patch v2 ] mm/zs_malloc: Fix bit spinlock replacement Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-10-19 18:00 +0200
    Re: [patch v2 ] mm/zs_malloc: Fix bit spinlock replacement Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-10-20 13:00 +0200

csiph-web