Groups > linux.kernel > #1501969

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

From	Shyam Saini <mayhs11saini@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'
Date	2016-10-17 15:40 +0200
Message-ID	<stgiZ-43Y-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fixed following checkpatch warning
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 8ed4d39..19b550f 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -38,7 +38,7 @@ static u8 bits_magic[] = {
 static struct platform_device	*firmware_pdev;
 
 static char	*file = "xlinx_fpga_firmware.bit";
-module_param(file, charp, S_IRUGO);
+module_param(file, charp, 0444);
 MODULE_PARM_DESC(file, "Xilinx FPGA firmware file.");
 
 static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize)
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/1] Staging: gs_fpgaboot:  Use octal permissions '0444' Shyam Saini <mayhs11saini@gmail.com> - 2016-10-17 15:40 +0200

csiph-web