Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501885

Re: [PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE.

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE.
Date 2016-10-17 13:20 +0200
Message-ID <ste7v-2Kh-19@gated-at.bofh.it> (permalink)
References (5 earlier) <sschs-2Xb-13@gated-at.bofh.it> <sscAO-33Q-17@gated-at.bofh.it> <ssrzP-4vF-1@gated-at.bofh.it> <st2J3-3P5-9@gated-at.bofh.it> <stbMm-19o-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon 17-10-16 10:42:44, Michal Hocko wrote:
[...]
> Sure, what do you think about the following? I haven't marked it for
> stable because there was no bug report for it AFAIU.

And 0-day robot just noticed that I've screwed and need the following on
top. If the patch makes sense I will repost it to Andrew with this
folded in.
---
diff --git a/mm/compaction.c b/mm/compaction.c
index df1fd0c20e5c..70e6bec46dc2 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -850,7 +850,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
 
 		/* Successfully isolated */
 		del_page_from_lru_list(page, lruvec, page_lru(page));
-		inc_node_page_state(zone->zone_pgdat,
+		inc_node_page_state(page,
 				NR_ISOLATED_ANON + page_is_file_cache(page));
 
 isolate_success:

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE. "ming.ling" <ming.ling@spreadtrum.com> - 2016-10-13 08:50 +0200
  Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-13 10:30 +0200
    Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Ming Ling <ming.ling@spreadtrum.com> - 2016-10-14 10:40 +0200
      Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-14 13:40 +0200
        Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Minchan Kim <minchan@kernel.org> - 2016-10-14 15:50 +0200
          Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-14 16:00 +0200
            Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Minchan Kim <minchan@kernel.org> - 2016-10-14 16:50 +0200
              Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-14 17:10 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Minchan Kim <minchan@kernel.org> - 2016-10-14 17:30 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-15 09:30 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Minchan Kim <minchan@kernel.org> - 2016-10-17 01:10 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-17 10:50 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-17 13:20 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Minchan Kim <minchan@kernel.org> - 2016-10-18 08:40 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Michal Hocko <mhocko@kernel.org> - 2016-10-18 15:00 +0200
                Re: [PATCH v2] mm: exclude isolated non-lru pages from  NR_ISOLATED_ANON or NR_ISOLATED_FILE. Ming Ling <ming.ling@spreadtrum.com> - 2016-10-19 04:40 +0200

csiph-web