Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501819

Re: [PATCH 1/2] ARM: oxnas: Add OX820 SMP support

Show all headers | View raw

On 10/17/2016 11:06 AM, Arnd Bergmann wrote:
> On Monday, October 17, 2016 10:43:02 AM CEST Neil Armstrong wrote:
>> +
>> +       /*
>> +        * This is really belt and braces; we hold unintended secondary
>> +        * CPUs in the holding pen until we're ready for them.  However,
>> +        * since we haven't sent them a soft interrupt, they shouldn't
>> +        * be there.
>> +        */
>> +       write_pen_release(cpu);
>> +
>> +       /*
>> +        * Enable GIC cpu interface in CPU Interface Control Register
>> +        */
>> +       writel(GIC_CPU_CTRL_ENABLE,
>> +               gic_cpu_ctrl + GIC_NCPU_OFFSET(cpu) + GIC_CPU_CTRL);
>> +
>> +       /*
>> +        * Send the secondary CPU a soft interrupt, thereby causing
>> +        * the boot monitor to read the system wide flags register,
>> +        * and branch to the address found there.
>> +        */
>> +
>> +       arch_send_wakeup_ipi_mask(cpumask_of(cpu));
>> +       timeout = jiffies + (1 * HZ);
>> +       while (time_before(jiffies, timeout)) {
>> +               smp_rmb();
>> +               if (read_pen_release() == -1)
>> +                       break;
>> +
>> +               udelay(10);
>> +       }
>>
> 
> This seems to have been copied from plat-versatile, but is really
> not needed here since you apparently have proper hardware support for
> starting up the CPUs.
Yes it seems.

> 
> Any reason you can't just write to the cpu_ctrl register
> once and keep going without that whole holding_pen loop
> and spinlock?
I suppose but I did not find any good examples except the plat-versatile code.
I will try some simpler code.

> 
> 	Arnd
> 

Neil

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ARM: oxnas: Add SMP support for OX820 Neil Armstrong <narmstrong@baylibre.com> - 2016-10-17 10:50 +0200
  [PATCH 1/2] ARM: oxnas: Add OX820 SMP support Neil Armstrong <narmstrong@baylibre.com> - 2016-10-17 10:50 +0200
    Re: [PATCH 1/2] ARM: oxnas: Add OX820 SMP support Arnd Bergmann <arnd@arndb.de> - 2016-10-17 11:10 +0200
      Re: [PATCH 1/2] ARM: oxnas: Add OX820 SMP support Neil Armstrong <narmstrong@baylibre.com> - 2016-10-17 11:40 +0200
  [PATCH 2/2] ARM: oxnas: Add OX820 config and makefile entry Neil Armstrong <narmstrong@baylibre.com> - 2016-10-17 10:50 +0200

csiph-web