Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501816
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus |
| Date | 2016-10-17 11:40 +0200 |
| Message-ID | <stcyJ-1Fs-15@gated-at.bofh.it> (permalink) |
| References | <srVzX-qJ-3@gated-at.bofh.it> <srVzY-qJ-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 13, 2016 at 02:15:27PM -0700, Andi Kleen wrote:
SNIP
> @@ -236,15 +237,32 @@ PE_KERNEL_PMU_EVENT sep_dc
> struct list_head *head;
> struct parse_events_term *term;
> struct list_head *list;
> + struct perf_pmu *pmu = NULL;
> + int ok = 0;
>
> - ALLOC_LIST(head);
> - ABORT_ON(parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
> - $1, 1, &@1, NULL));
> - list_add_tail(&term->list, head);
> -
> + /* Add it for all PMUs that support the alias */
> ALLOC_LIST(list);
> - ABORT_ON(parse_events_add_pmu(data, list, "cpu", head));
> - parse_events_terms__delete(head);
> + while ((pmu = perf_pmu__scan(pmu)) != NULL) {
> + struct perf_pmu_alias *alias;
> +
> + list_for_each_entry(alias, &pmu->aliases, list) {
> + if (!strcasecmp(alias->name, $1)) {
> + ALLOC_LIST(head);
> + ABORT_ON(parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
> + $1, 1, &@1, NULL));
> + list_add_tail(&term->list, head);
> +
> + if (!parse_events_add_pmu(data, list,
> + pmu->name, head)) {
> + ok++;
> + }
> +
> + parse_events_terms__delete(head);
> + }
> + }
> + }
> + if (!ok)
> + YYABORT;
> $$ = list;
> }
> |
how about the next rule:
PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
I think that must be changed as well
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Support Intel uncore event lists Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
[PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:00 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:30 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen <andi@firstfloor.org> - 2016-10-17 18:40 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Jiri Olsa <jolsa@redhat.com> - 2016-10-17 19:30 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen <ak@linux.intel.com> - 2016-10-17 20:20 +0200
Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:30 +0200
[PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 08/10] perf, tools: Expand PMU events by prefix match Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:40 +0200
Re: [PATCH 08/10] perf, tools: Expand PMU events by prefix match Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:50 +0200
Re: [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen <andi@firstfloor.org> - 2016-10-17 19:20 +0200
Re: [PATCH 08/10] perf, tools: Expand PMU events by prefix match Jiri Olsa <jolsa@redhat.com> - 2016-10-17 19:30 +0200
[PATCH 02/10] perf, tools: Only print Using CPUID message once Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 02/10] perf, tools: Only print Using CPUID message once Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-14 17:50 +0200
[tip:perf/core] perf pmu: Only print Using CPUID message once tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-10-24 21:10 +0200
[PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:50 +0200
Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen <andi@firstfloor.org> - 2016-10-17 18:30 +0200
Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Jiri Olsa <jolsa@redhat.com> - 2016-10-17 19:50 +0200
Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Jiri Olsa <jolsa@redhat.com> - 2016-10-17 19:50 +0200
Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen <andi@firstfloor.org> - 2016-10-17 20:30 +0200
[PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 04/10] perf, tools: Support per pmu json aliases Jiri Olsa <jolsa@redhat.com> - 2016-10-14 14:40 +0200
[PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Jiri Olsa <jolsa@redhat.com> - 2016-10-17 11:40 +0200
Re: [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Jiri Olsa <jolsa@redhat.com> - 2016-10-17 12:30 +0200
[PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-14 17:40 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen <andi@firstfloor.org> - 2016-10-14 17:50 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-14 18:20 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen <ak@linux.intel.com> - 2016-10-14 18:20 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-14 18:30 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-14 18:40 +0200
Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen <andi@firstfloor.org> - 2016-10-14 18:40 +0200
[PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
[PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen <andi@firstfloor.org> - 2016-10-13 23:20 +0200
Re: Support Intel uncore event lists Jiri Olsa <jolsa@redhat.com> - 2016-10-17 13:10 +0200
csiph-web