Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503644

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()
Date 2016-10-19 16:20 +0200
Message-ID <stZSQ-2nd-159@gated-at.bofh.it> (permalink)
References (1 earlier) <ss99V-JJ-65@gated-at.bofh.it> <qEuGl-43C-5@gated-at.bofh.it> <ss99T-JJ-1@gated-at.bofh.it> <stZSQ-2nd-163@gated-at.bofh.it> <stZSQ-2nd-165@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>>>> Move the setting for the local variables "mask", "match" and "rc6_csl"
>>>> behind the source code for a condition check by this function
>>>> at the beginning.
>>>
>>> Again, I can't see what the point is?
>>
>> * How do you think about to set these variables only after the initial
>> check succeded?
> 
> I prefer setting variables early so that no thinking about
> whether they're initialized or not is necessary later.

* How do you think about to reduce the scope for these variables then?

* Would you dare to move the corresponding source code into a separate function?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] [media] winbond-cir: Fine-tuning for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
  [PATCH 2/5] [media] winbond-cir: Move a variable assignment in  wbcir_tx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
    Re: [PATCH 2/5] [media] winbond-cir: Move a variable assignment  in wbcir_tx() "David Härdeman" <david@hardeman.nu> - 2016-10-19 17:40 +0200
      Re: [media] winbond-cir: Move a variable assignment in wbcir_tx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 18:30 +0200
  [PATCH 5/5] [media] winbond-cir: Move a variable assignment in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
    Re: [PATCH 5/5] [media] winbond-cir: Move a variable assignment  in two functions "David Härdeman" <david@hardeman.nu> - 2016-10-19 16:30 +0200
  [PATCH 4/5] [media] winbond-cir: One variable and its check less in  wbcir_shutdown() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
    Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less  in wbcir_shutdown() after error detection Sean Young <sean@mess.org> - 2016-10-15 15:40 +0200
      Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less  in wbcir_shutdown() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-15 18:50 +0200
        Re: [PATCH 4/5] [media] winbond-cir: One variable and its check  less in wbcir_shutdown() after error detection "David Härdeman" <david@hardeman.nu> - 2016-10-19 16:30 +0200
          Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less  in wbcir_shutdown() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 18:30 +0200
      Re: [PATCH 4/5] [media] winbond-cir: One variable and its check  less in wbcir_shutdown() after error detection "David Härdeman" <david@hardeman.nu> - 2016-10-19 16:30 +0200
  [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir_tx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
    Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in  wbcir_tx() "David Härdeman" <david@hardeman.nu> - 2016-10-19 17:40 +0200
  [PATCH 3/5] [media] winbond-cir: Move assignments for three variables  in wbcir_shutdown() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-14 13:50 +0200
    Re: [PATCH 3/5] [media] winbond-cir: Move assignments for three  variables in wbcir_shutdown() "David Härdeman" <david@hardeman.nu> - 2016-10-19 16:30 +0200
      Re: [media] winbond-cir: Move assignments for three variables in  wbcir_shutdown() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 16:30 +0200
        Re: [media] winbond-cir: Move assignments for three variables in  wbcir_shutdown() "David Härdeman" <david@hardeman.nu> - 2016-10-19 17:50 +0200
  Re: [media] winbond-cir: Move a variable assignment in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 16:20 +0200
  Re: [media] winbond-cir: Move a variable assignment in wbcir_tx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 16:20 +0200
  Re: [media] winbond-cir: Move assignments for three variables in  wbcir_shutdown() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-19 16:20 +0200
  Re: [media] winbond-cir: Move a variable assignment in wbcir_tx() "David Härdeman" <david@hardeman.nu> - 2016-10-19 16:30 +0200

csiph-web