Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}
Date	2016-10-19 16:30 +0200
Message-ID	<stZSO-2nd-63@gated-at.bofh.it> (permalink)
References	<stZSO-2nd-55@gated-at.bofh.it> <stZSO-2nd-57@gated-at.bofh.it> <stZSO-2nd-59@gated-at.bofh.it> <stZSO-2nd-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote:
> Ok, I'll rework my patch series to stick with the direct returns. I
> personally prefer that approach. I was using the gotos since I thought
> that was standard convention in the kernel.
> 

It *should* but "goto unlock;"  When you can tell what the goto does,
that's great.  But these gotos don't do anything so by definition the
names are going to be meaningless.

regards,
dan carpenter

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/7] iio: light: tsl2583: check return values from  taos_chip_{on, off} Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-19 16:30 +0200

csiph-web