Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503564

Re: [PATCH 4/4] i2c: digicolor: Fix module autoload

Show all headers | View raw

Hi Javier Martinez Canillas,

On Tue, Oct 18, 2016 at 06:01:48PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias
> alias:          of:N*T*Ccnxt,cx92755-i2cC*
> alias:          of:N*T*Ccnxt,cx92755-i2c
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

>  drivers/i2c/busses/i2c-digicolor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
> index 9604024e0eb0..49f2084f7bb5 100644
> --- a/drivers/i2c/busses/i2c-digicolor.c
> +++ b/drivers/i2c/busses/i2c-digicolor.c
> @@ -368,6 +368,7 @@ static const struct of_device_id dc_i2c_match[] = {
>  	{ .compatible = "cnxt,cx92755-i2c" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, dc_i2c_match);
>  
>  static struct platform_driver dc_i2c_driver = {
>  	.probe   = dc_i2c_probe,

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 23:10 +0200
  [PATCH 3/4] i2c: xlr: Fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 23:10 +0200
  [PATCH 2/4] i2c: xlp9xx: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 23:10 +0200
  [PATCH 4/4] i2c: digicolor: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 23:10 +0200
    Re: [PATCH 4/4] i2c: digicolor: Fix module autoload Baruch Siach <baruch@tkos.co.il> - 2016-10-19 07:10 +0200
  [PATCH 1/4] i2c: jz4780: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 23:10 +0200
  Re: [PATCH 0/4] i2c: Fix module autoload for some i2c busses  platform drivers Wolfram Sang <wsa@the-dreams.de> - 2016-10-25 11:40 +0200

csiph-web