Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

From	Vaibhav Agarwal <vaibhav.sr@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: greybus: audio: Rename cport with intf_id
Date	2016-10-19 07:40 +0200
Message-ID	<stRLA-53l-3@gated-at.bofh.it> (permalink)
References	<ssQyd-4r4-3@gated-at.bofh.it> <stib7-5fR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 17, 2016 at 9:01 PM, Johan Hovold <johan@kernel.org> wrote:
> On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote:
>> gb_audio_manager_module_descriptor's cport field is actually used to
>> manage and pass interface id to user space.
>>
>> Thus rename gb_audio_manager_module_descriptor's 'cport' field and
>> few other things to avoid confusion.
>
> Please be more specific about what these other things are; in this case
> sysfs attributes, uevent vars, and an odd-looking sysfs-string
> interface (more?).
>
> Wouldn't this change break any current user-space implementation?

Yes, it would require changes in user space code as well. For now, it
should be GMP-Audio HAL only.

>
> Also why aren't any of these attributes documented as they should be?

Currently, none of GB Audio specific sysfs entries are documented.
I'll share another patch for this.

--
thanks,
./va

>
> Thanks,
> Johan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: greybus: audio: Rename cport with intf_id Pankaj Bharadiya <pankaj.bharadiya@gmail.com> - 2016-10-16 12:10 +0200
  Re: [PATCH] staging: greybus: audio: Rename cport with intf_id Vaibhav Agarwal <vaibhav.sr@gmail.com> - 2016-10-17 05:30 +0200
  Re: [PATCH] staging: greybus: audio: Rename cport with intf_id Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-17 08:00 +0200
  Re: [PATCH] staging: greybus: audio: Rename cport with intf_id Johan Hovold <johan@kernel.org> - 2016-10-17 17:40 +0200
    Re: [PATCH] staging: greybus: audio: Rename cport with intf_id Vaibhav Agarwal <vaibhav.sr@gmail.com> - 2016-10-19 07:40 +0200

csiph-web