Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1503413

Re: [PATCH 1/8] tools lib bpf: add error functions

From Joe Stringer <joe@ovn.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/8] tools lib bpf: add error functions
Date 2016-10-19 01:00 +0200
Message-ID <stLwu-cZ-9@gated-at.bofh.it> (permalink)
References <st1MZ-3dc-3@gated-at.bofh.it> <st1N0-3dc-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 16 October 2016 at 14:18, Eric Leblond <eric@regit.org> wrote:
> The include of err.h is not explicitely needed in exported
> functions and it was causing include conflict with some existing
> code due to redefining some macros.
>
> To fix this, let's have error handling functions provided by the
> library. Furthermore this will allow user to have an homogeneous
> API.
>
> Signed-off-by: Eric Leblond <eric@regit.org>

Does it need to return the error like this or should we just fix up
the bpf_object__open() API to return errors in a simpler form?

There's already libbpf_set_print(...) for outputting errors, is it
reasonable to just change the library to return NULLs in error cases
instead?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/8] tools lib bpf: add error functions Eric Leblond <eric@regit.org> - 2016-10-17 00:10 +0200
  Re: [PATCH 1/8] tools lib bpf: add error functions "Wangnan (F)" <wangnan0@huawei.com> - 2016-10-17 04:00 +0200
  Re: [PATCH 1/8] tools lib bpf: add error functions Joe Stringer <joe@ovn.org> - 2016-10-19 01:00 +0200
    Re: [PATCH 1/8] tools lib bpf: add error functions "Wangnan (F)" <wangnan0@huawei.com> - 2016-10-19 04:00 +0200

csiph-web