Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503288

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

Show all headers | View raw

On 2016-10-18 07:28, Vivek Gautam wrote:
> From: Yaniv Gardi <ygardi@codeaurora.org>
> 
> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk
> are no longer exist, we should not fail when their initialization
> fail, but rather just report with debug message.

You may also want to update the device tree binding (documentation) to 
update these as optional properties.

> 
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> 
> No change since v1.
> 
>  drivers/phy/phy-qcom-ufs.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index 107cb57..183ec04 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -186,16 +186,27 @@ ufs_qcom_phy_init_clks(struct phy *generic_phy,
>  		       struct ufs_qcom_phy *phy_common)
>  {
>  	int err;
> +	struct ufs_qcom_phy *phy = get_ufs_qcom_phy(generic_phy);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "tx_iface_clk",
>  				   &phy_common->tx_iface_clk);
> +	/*
> +	 * tx_iface_clk does not exist in newer version of ufs-phy HW,
> +	 * so don't return error if it is not found
> +	 */
>  	if (err)
> -		goto out;
> +		dev_dbg(phy->dev, "%s: failed to get tx_iface_clk\n",
> +			__func__);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "rx_iface_clk",
>  				   &phy_common->rx_iface_clk);
> +	/*
> +	 * rx_iface_clk does not exist in newer version of ufs-phy HW,
> +	 * so don't return error if it is not found
> +	 */
>  	if (err)
> -		goto out;
> +		dev_dbg(phy->dev, "%s: failed to get rx_iface_clk\n",
> +			__func__);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "ref_clk_src",
>  				   &phy_common->ref_clk_src);

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
  [PATCH v2 07/10] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
  [PATCH v2 02/10] phy: qcom-ufs: Remove unnecessary BUG_ON Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
  [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
    Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when  rx/tx_iface_clk are absent Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-18 20:40 +0200
    Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when  rx/tx_iface_clk are absent Stephen Boyd <sboyd@codeaurora.org> - 2016-10-18 23:20 +0200
      Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when  rx/tx_iface_clk are absent Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-19 19:30 +0200
  [PATCH v2 10/10] phy: qcom-ufs: Remove common layer phy exit callback Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
    Re: [PATCH v2 10/10] phy: qcom-ufs: Remove common layer phy exit  callback Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-19 02:10 +0200
  [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
    Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-18 22:20 +0200
      Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-19 19:50 +0200
        Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-19 21:20 +0200
          Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-20 05:50 +0200
  [PATCH v2 06/10] phy: qcom-ufs: Remove unnecessary function declarations Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:30 +0200
    Re: [PATCH v2 06/10] phy: qcom-ufs: Remove unnecessary function  declarations Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-18 20:50 +0200
  [PATCH v2 05/10] phy: qcom-ufs: Cleanup clock and regulator initialization Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:40 +0200
  [PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers. Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:40 +0200
    Re: [PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback  for drivers. Kishon Vijay Abraham I <kishon@ti.com> - 2016-10-26 22:30 +0200
  [PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit path Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 16:40 +0200
    Re: [PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit  path Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-18 22:20 +0200
  Re: [PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-10-25 02:50 +0200
    Re: [PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and  ufs-qcom hcd Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-25 08:10 +0200

csiph-web