Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503284
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver |
| Date | 2016-10-18 20:40 +0200 |
| Message-ID | <stHsR-5Dk-1@gated-at.bofh.it> (permalink) |
| References | <stAKK-WC-11@gated-at.bofh.it> <stAUp-108-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Tue, 18 Oct 2016 13:27:34 +0200
> +void
> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
> + int count)
> +{
> + struct qcauart *qca = tty->disc_data;
> + struct net_device_stats *n_stats = &qca->net_dev->stats;
> + int dropped = 0;
Please order local variable declarations from longest to shortest line.
> +netdev_tx_t
> +qcauart_netdev_xmit(struct sk_buff *skb, struct net_device *dev)
> +{
> + struct qcauart *qca = netdev_priv(dev);
> + struct net_device_stats *n_stats = &dev->stats;
> + u8 *pos;
> + u8 pad_len = 0;
> + int written;
Likewise.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 net-next 0/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-10-18 13:40 +0200
[PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-10-18 13:40 +0200
Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver David Miller <davem@davemloft.net> - 2016-10-18 20:40 +0200
Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-10-21 13:40 +0200
csiph-web