Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503204

Re: [PATCH 07/13] bindings: gpio-sx150x: Document "semtech,io-pull*" bindings

Show all headers | View raw

On Mon, Oct 17, 2016 at 07:27:02AM -0700, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-sx150x.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt b/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> index 02b92ae..7574137 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> @@ -35,6 +35,14 @@ Optional properties:
>    		       polarity. For chips with fewer than 16 IO pins,
>    		       high-end bits are ignored.
>  
> +- semtech,io-pullup:
> +- semtech,io-pulldown: A bit-mask which enables-or disables the
> +  		       pull-up (pull-down) resistor for each IO line
> +  		       in the expander. Setting the bit at position n
> +  		       will enable the pull-down for the IO at the
> +  		       corresponding offset.  For chips with fewer
> +  		       than 16 IO pins, high-end bits are ignored.
> +

I take my ack back. Please put all DT changes in one patch to review as 
a whole. Drivers may evolve with features, but h/w description should 
not.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 07/13] bindings: gpio-sx150x: Document "semtech,io-pull*" bindings Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-10-17 16:30 +0200
  Re: [PATCH 07/13] bindings: gpio-sx150x: Document "semtech,io-pull*"  bindings Rob Herring <robh@kernel.org> - 2016-10-18 18:30 +0200

csiph-web