Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503200
| From | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Linux-kernel] [PATCH] tty: serial: 8250: add CON_CONSDEV to flags |
| Date | 2016-10-18 18:30 +0200 |
| Message-ID | <stFr3-4cE-7@gated-at.bofh.it> (permalink) |
| References | <rMvMK-7AG-19@gated-at.bofh.it> <stFho-49i-7@gated-at.bofh.it> |
| Organization | Codethink Limited. |
On 18/10/16 17:15, Jiri Slaby wrote:
> On 06/21/2016, 05:19 PM, Matthew Leach wrote:
>> When using the 8250 as a boot console and the main console results in
>> messages being printed twice. The console framework will only
>> unregister boot consoles if a new console is registered with the
>> CON_CONSDEV flag set.
>>
>> Set this flag for the univ8250 console to prevent double-registration.
>>
>> Signed-off-by: Matthew Leach <matthew.leach@codethink.co.uk>
>> ---
>> drivers/tty/serial/8250/8250_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
>> index 2f4f5ee..7a7453d 100644
>> --- a/drivers/tty/serial/8250/8250_core.c
>> +++ b/drivers/tty/serial/8250/8250_core.c
>> @@ -675,7 +675,7 @@ static struct console univ8250_console = {
>> .device = uart_console_device,
>> .setup = univ8250_console_setup,
>> .match = univ8250_console_match,
>> - .flags = CON_PRINTBUFFER | CON_ANYTIME,
>> + .flags = CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV,
>
> This patch breaks console= parameter handling. Passing:
> console=ttyS0 console=tty0
> no longer means /dev/console is tty0 and it should be as is documented.
>
> I have not investigated further yet.
Ok, thanks.
I'll need to find Matthew Leach's new address as he's moved jobs.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] tty: serial: 8250: add CON_CONSDEV to flags Jiri Slaby <jslaby@suse.cz> - 2016-10-18 18:20 +0200
Re: [Linux-kernel] [PATCH] tty: serial: 8250: add CON_CONSDEV to flags Ben Dooks <ben.dooks@codethink.co.uk> - 2016-10-18 18:30 +0200
Re: [Linux-kernel] [PATCH] tty: serial: 8250: add CON_CONSDEV to flags Jiri Slaby <jslaby@suse.cz> - 2016-10-18 19:00 +0200
csiph-web