[PATCH v2] tty: serial_core: Fix serial console crash on port shutdown

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert+renesas@glider.be>
Newsgroups	linux.kernel
Subject	[PATCH v2] tty: serial_core: Fix serial console crash on port shutdown
Date	Tue, 18 Oct 2016 18:40:02 +0200
Message-ID	<stFAK-4gM-27@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 1.9.1
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>, Rob Herring <robh@kernel.org>, Peter Hurley <peter@hurleysoftware.com>, Alan Cox <alan@linux.intel.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>
X-Original-Date	Tue, 18 Oct 2016 18:35:40 +0200
X-Original-Message-ID	<1476808540-2757-1-git-send-email-geert+renesas@glider.be>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1503214

Show key headers only | View raw

The port->console flag is always false, as uart_console() is called
before the serial console has been registered.

Hence for a serial port used as the console, uart_tty_port_shutdown()
will still be called when userspace closes the port, powering it down.
This may lead to a system lock up when the serial console driver writes
to the serial port's registers.

To fix this, move the setting of port->console after the call to
uart_configure_port(), which registers the serial console.

Fixes: 761ed4a94582ab29 ("tty: serial_core: convert uart_close to use tty_port_close")
Reported-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
---
v2:
  - Add Acked-by,
  - Reworded one-line summary (incl. magic word "fix").

Can easily be reproduced on Renesas boards:
  1. With systemd: hangs during boot,
  2. Without systemd: "telinit n" to switch to a runlevel that doesn't
     run a getty on ttySC0, and trigger kernel console output => hang.
---
 drivers/tty/serial/serial_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 6e4f63627479db8d..ce8899c13af3d97f 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2746,8 +2746,6 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 	uport->cons = drv->cons;
 	uport->minor = drv->tty_driver->minor_start + uport->line;
 
-	port->console = uart_console(uport);
-
 	/*
 	 * If this port is a console, then the spinlock is already
 	 * initialised.
@@ -2761,6 +2759,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 
 	uart_configure_port(drv, state, uport);
 
+	port->console = uart_console(uport);
+
 	num_groups = 2;
 	if (uport->attr_group)
 		num_groups++;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] tty: serial_core: Fix serial console crash on port shutdown Geert Uytterhoeven <geert+renesas@glider.be> - 2016-10-18 18:40 +0200
  Re: [v2] tty: serial_core: Fix serial console crash on port shutdown Mugunthan V N <mugunthanvnm@ti.com> - 2016-10-19 11:10 +0200
  Re: [PATCH v2] tty: serial_core: Fix serial console crash on port  shutdown "Niklas Söderlund" <niklas.soderlund@ragnatech.se> - 2016-10-19 17:50 +0200

csiph-web