Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503155

Re: [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind

Show all headers | View raw

On Tue, Oct 18, 2016 at 2:14 AM, Zain Wang <wzz@rock-chips.com> wrote:
> From: zain wang <wzz@rock-chips.com>
>
> phy_power_on() and analogix_dp_init_dp would be called in bridge_eanble,
> so remove them from analogix_dp_bind to be clear.
>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> Signed-off-by: zain wang <wzz@rock-chips.com>
> ---
>
> Changes in v3:
> - remove changes before
> - remove phy_power_on() and analogix_dp_init_dp from analogix_dp_bind().
>
> Changes in v2: None
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 001b075..bcae4dd 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1389,10 +1389,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
>
>         pm_runtime_enable(dev);
>
> -       phy_power_on(dp->phy);
> -
> -       analogix_dp_init_dp(dp);
> -
>         ret = devm_request_threaded_irq(&pdev->dev, dp->irq,
>                                         analogix_dp_hardirq,
>                                         analogix_dp_irq_thread,
> --
> 1.9.1
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] Misc changes to Rockchip PSR drivers Zain Wang <wzz@rock-chips.com> - 2016-10-18 08:20 +0200
  [PATCH v3 1/6] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge Zain Wang <wzz@rock-chips.com> - 2016-10-18 08:20 +0200
    Re: [PATCH v3 1/6] drm/bridge: analogix_dp: set psr  activate/deactivate when enable/disable bridge Sean Paul <seanpaul@chromium.org> - 2016-10-18 18:00 +0200
  [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind Zain Wang <wzz@rock-chips.com> - 2016-10-18 08:20 +0200
    Re: [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind Sean Paul <seanpaul@chromium.org> - 2016-10-18 18:00 +0200

csiph-web