Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503026

Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations

Show all headers | View raw

On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote:
> Hi,
> 
> On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote :
> > Change since v1:
> > - restored __exit for module_exit function
> > 
> > ---8<---
> 
> I don't think this is the proper scissor symbol for git. At least, it is
> no recognized by patchwork and messes your patch.
> 
> > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001
> > From: Corentin Labbe <clabbe.montjoie@gmail.com>
> > Date: Mon, 17 Oct 2016 14:17:49 +0200
> > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations
> > 
> > I got the following stack trace under qemu:
> 
> [...]
> > When cmos_set_alarm() is called dev is NULL and so trigger the deref via
> > cmos->irq
> > 
> > The problem comes from that the device is removed but no remove function
> > are called due to _exit_p().
> > 
> > This patch remove all _exit_p() annotation.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> 
> 
> The changelog should go here.
> 
> >  drivers/rtc/rtc-cmos.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 

Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump it to v3.

Regards

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] rtc: cmos: remove all __exit_p annotations Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-18 14:00 +0200
  Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-10-18 16:20 +0200
    Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-10-18 16:30 +0200
      Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-10-18 16:40 +0200

csiph-web