Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501622

[PATCH 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported

Show all headers | View raw

From: Niklas Cassel <niklas.cassel@axis.com>

phy_device->supported is originally set by the PHY driver.
The ethernet driver should filter phy_device->supported to only contain
flags supported by the IP.
The IP supports setting rx and tx flow control independently,
therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
If the flags are cleared, pause frames cannot be enabled (even if they
are supported by the PHY).

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Lars Persson <larper@axis.com>
---
 drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index c9891eac9775..93a3a919f723 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -985,7 +985,8 @@ static int dwceqos_mii_probe(struct net_device *ndev)
 			   "phydev %p, phydev->phy_id 0xa%x, phydev->addr 0x%x\n",
 			   phydev, phydev->phy_id, phydev->addr);
 
-	phydev->supported &= PHY_GBIT_FEATURES;
+	phydev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause |
+			     SUPPORTED_Asym_Pause;
 
 	lp->link    = 0;
 	lp->speed   = 0;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel <niklas.cassel@axis.com> - 2016-10-17 08:30 +0200
  Re: [PATCH 1/2] dwc_eth_qos: do not clear pause flags from  phy_device->supported David Miller <davem@davemloft.net> - 2016-10-17 19:00 +0200

csiph-web