Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501308
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 6/7] ASoC: constify snd_soc_ops structures |
| Date | 2016-10-15 17:20 +0200 |
| Message-ID | <ssyUG-Tt-27@gated-at.bofh.it> (permalink) |
| References | <ssyUF-Tt-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Check for snd_soc_ops structures that are only stored in the ops field of a
snd_soc_dai_link structure. This field is declared const, so snd_soc_ops
structures that have this property can be declared as const also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_soc_ops i@p = { ... };
@ok1@
identifier r.i;
struct snd_soc_dai_link e;
position p;
@@
e.ops = &i@p;
@ok2@
identifier r.i, e;
position p;
@@
struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_soc_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct snd_soc_ops i = { ... };
// </smpl>
The effect on the layout of the .o files is shown by the following output of
the size command, first before then after the transformation:
text data bss dec hex filename
8748 1024 0 9772 262c sound/soc/fsl/fsl-asoc-card.o
8812 952 0 9764 2624 sound/soc/fsl/fsl-asoc-card.o
text data bss dec hex filename
4165 264 8 4437 1155 sound/soc/fsl/imx-wm8962.o
4229 200 8 4437 1155 sound/soc/fsl/imx-wm8962.o
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/soc/fsl/fsl-asoc-card.c | 2 +-
sound/soc/fsl/imx-wm8962.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -u -p a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -183,7 +183,7 @@ static int fsl_asoc_card_hw_params(struc
return 0;
}
-static struct snd_soc_ops fsl_asoc_card_ops = {
+static const struct snd_soc_ops fsl_asoc_card_ops = {
.hw_params = fsl_asoc_card_hw_params,
};
diff -u -p a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
--- a/sound/soc/fsl/imx-wm8962.c
+++ b/sound/soc/fsl/imx-wm8962.c
@@ -61,7 +61,7 @@ static int imx_hifi_hw_params(struct snd
return 0;
}
-static struct snd_soc_ops imx_hifi_ops = {
+static const struct snd_soc_ops imx_hifi_ops = {
.hw_params = imx_hifi_hw_params,
};
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
[PATCH 1/7] ASoC: intel: broadwell: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Re: [alsa-devel] [PATCH 1/7] ASoC: intel: broadwell: constify snd_soc_ops structures Keyon Jie <yang.jie@linux.intel.com> - 2016-10-17 04:30 +0200
Applied "ASoC: intel: broadwell: constify snd_soc_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:10 +0200
[PATCH 3/7] ASoC: rockchip: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Applied "ASoC: rockchip: constify snd_soc_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:10 +0200
[PATCH 4/7] ASoC: qcom: storm: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:10 +0200
[PATCH 7/7] ASoC: tegra: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Applied "ASoC: tegra: constify snd_soc_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:10 +0200
[PATCH 6/7] ASoC: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Applied "ASoC: constify snd_soc_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-10-24 20:10 +0200
[PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-15 17:20 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Mark Brown <broonie@kernel.org> - 2016-10-24 19:40 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-10-24 21:50 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-10-25 08:00 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Joe Perches <joe@perches.com> - 2016-10-25 10:10 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-10-25 10:50 +0200
Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures Mark Brown <broonie@kernel.org> - 2016-10-25 16:10 +0200
csiph-web