Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501095

Re: [PATCH 2/2] watchdog: max77620_wdt: fix module autoload

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] watchdog: max77620_wdt: fix module autoload
Date 2016-10-14 19:00 +0200
Message-ID <ssdZY-3Nv-9@gated-at.bofh.it> (permalink)
References <sscAN-33Q-11@gated-at.bofh.it> <sscAO-33Q-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Oct 14, 2016 at 12:23:51PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ $ modinfo drivers/watchdog/max77620_wdt.ko | grep alias
> $
> 
> After this patch:
> 
> modinfo drivers/watchdog/max77620_wdt.ko | grep alias
> alias:          platform:max77620-watchdog
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
>  drivers/watchdog/max77620_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c
> index 48b84df2afda..68c41fa2be27 100644
> --- a/drivers/watchdog/max77620_wdt.c
> +++ b/drivers/watchdog/max77620_wdt.c
> @@ -205,6 +205,7 @@ static struct platform_device_id max77620_wdt_devtype[] = {
>  	{ .name = "max77620-watchdog", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(platform, max77620_wdt_devtype);
>  
>  static struct platform_driver max77620_wdt_driver = {
>  	.driver	= {
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 17:30 +0200
  [PATCH 2/2] watchdog: max77620_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 17:30 +0200
    Re: [PATCH 2/2] watchdog: max77620_wdt: fix module autoload Guenter Roeck <linux@roeck-us.net> - 2016-10-14 19:00 +0200
  Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Guenter Roeck <linux@roeck-us.net> - 2016-10-14 19:00 +0200

csiph-web