Re: [PATCH 2/3] thermal: tango: Fix module autoload

From	Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] thermal: tango: Fix module autoload
Date	2016-10-14 17:40 +0200
Message-ID	<sscKu-36Y-9@gated-at.bofh.it> (permalink)
References	<ssbOp-2ti-3@gated-at.bofh.it> <ssbOq-2ti-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14/10/2016 16:35, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/thermal/tango_thermal.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/thermal/tango_thermal.ko | grep alias
> alias:          of:N*T*Csigma,smp8758-thermalC*
> alias:          of:N*T*Csigma,smp8758-thermal
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/thermal/tango_thermal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
> index 201304aeafeb..4e67795cb6ce 100644
> --- a/drivers/thermal/tango_thermal.c
> +++ b/drivers/thermal/tango_thermal.c
> @@ -107,6 +107,7 @@ static const struct of_device_id tango_sensor_ids[] = {
>  	},
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, tango_sensor_ids);

Thanks for fixing it :-)

Acked-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>

Regards.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] thermal: Fix module autoload for drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 16:40 +0200
  [PATCH 2/3] thermal: tango: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 16:40 +0200
    Re: [PATCH 2/3] thermal: tango: Fix module autoload Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-10-14 17:40 +0200

csiph-web