Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501019

Re: [PATCH] leds: lp3952: Export I2C module alias information for module autoload

From Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] leds: lp3952: Export I2C module alias information for module autoload
Date 2016-10-14 16:00 +0200
Message-ID <ssbbI-1Xc-15@gated-at.bofh.it> (permalink)
References <ssbbI-1Xc-17@gated-at.bofh.it> <ss9MC-1cq-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Javier,

Thanks for the patch.
Applied to the for-4.10 branch of linux-leds.git.

Best regards,
Jacek Anaszewski

On 10/14/2016 02:23 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, I2C module alias information is not
> filled so the module won't be autoloaded if the device isn't registered
> over ACPI. Export the I2C device table alias with MODULE_DEVICE_TABLE()
> macro so the information is exported in the module.
>
> Before this patch:
>
> $ modinfo drivers/leds/leds-lp3952.ko | grep alias
> alias:          acpi*:TXNW3952:*
>
> After this patch:
>
> $ modinfo drivers/leds/leds-lp3952.ko | grep alias
> alias:          i2c:lp3952
> alias:          acpi*:TXNW3952:*
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
>  drivers/leds/leds-lp3952.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-lp3952.c b/drivers/leds/leds-lp3952.c
> index a73c8ff08530..4847e89883a7 100644
> --- a/drivers/leds/leds-lp3952.c
> +++ b/drivers/leds/leds-lp3952.c
> @@ -274,6 +274,7 @@ static const struct i2c_device_id lp3952_id[] = {
>  	{LP3952_NAME, 0},
>  	{}
>  };
> +MODULE_DEVICE_TABLE(i2c, lp3952_id);
>
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id lp3952_acpi_match[] = {
>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] leds: lp3952: Export I2C module alias information for module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 14:30 +0200
  Re: [PATCH] leds: lp3952: Export I2C module alias information for  module autoload Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-10-14 16:00 +0200

csiph-web