[PATCH v5 6/6] sched/fair: Fix wrong comment for capacity_margin

From	Morten Rasmussen <morten.rasmussen@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH v5 6/6] sched/fair: Fix wrong comment for capacity_margin
Date	2016-10-14 15:50 +0200
Message-ID	<ssb22-1TI-47@gated-at.bofh.it> (permalink)
References	<ssb21-1TI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The comment for capacity_margin introduced in "sched/fair: Let
asymmetric cpu configurations balance at wake-up" got its usage the
wrong way round.

cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>

Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e0abff77764f..08408d6405a5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -116,7 +116,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL;
 
 /*
  * The margin used when comparing utilization with CPU capacity:
- * util * 1024 < capacity * margin
+ * util * margin < capacity * 1024
  */
 unsigned int capacity_margin = 1280; /* ~20% */
 
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v5 6/6] sched/fair: Fix wrong comment for capacity_margin Morten Rasmussen <morten.rasmussen@arm.com> - 2016-10-14 15:50 +0200

csiph-web