Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500777

[PATCH v2] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

Show all headers | View raw

Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.

Signed-off-by: Mikhail Golubev <golubev.mikhail@gmail.com>
---
Changes in v2:
  - Make the changelog comment wrapped at 72 columns.

 drivers/staging/vt6656/baseband.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h
index 7cc1387..fe1c25c 100644
--- a/drivers/staging/vt6656/baseband.h
+++ b/drivers/staging/vt6656/baseband.h
@@ -86,15 +86,15 @@ struct vnt_phy_field {
 unsigned int vnt_get_frame_time(u8 preamble_type, u8 pkt_type,
 				unsigned int frame_length, u16 tx_rate);
 
-void vnt_get_phy_field(struct vnt_private *, u32 frame_length,
-		       u16 tx_rate, u8 pkt_type, struct vnt_phy_field *);
-
-void vnt_set_short_slot_time(struct vnt_private *);
-void vnt_set_vga_gain_offset(struct vnt_private *, u8);
-void vnt_set_antenna_mode(struct vnt_private *, u8);
-int vnt_vt3184_init(struct vnt_private *);
-void vnt_set_deep_sleep(struct vnt_private *);
-void vnt_exit_deep_sleep(struct vnt_private *);
-void vnt_update_pre_ed_threshold(struct vnt_private *, int scanning);
+void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
+		       u16 tx_rate, u8 pkt_type, struct vnt_phy_field *phy);
+
+void vnt_set_short_slot_time(struct vnt_private *priv);
+void vnt_set_vga_gain_offset(struct vnt_private *priv, u8 data);
+void vnt_set_antenna_mode(struct vnt_private *priv, u8 antenna_mode);
+int vnt_vt3184_init(struct vnt_private *priv);
+void vnt_set_deep_sleep(struct vnt_private *priv);
+void vnt_exit_deep_sleep(struct vnt_private *priv);
+void vnt_update_pre_ed_threshold(struct vnt_private *priv, int scanning);
 
 #endif /* __BASEBAND_H__ */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue Mikhail Golubev <golubev.mikhail@gmail.com> - 2016-10-13 14:00 +0200
  Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 14:20 +0200
    Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Mikhail Golubev <golubev.mikhail@gmail.com> - 2016-10-13 16:30 +0200
      Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 18:00 +0200
        Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Joe Perches <joe@perches.com> - 2016-10-13 18:40 +0200
          Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Joe Perches <joe@perches.com> - 2016-10-13 19:00 +0200
          Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition  argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-13 19:10 +0200
    [PATCH v2] staging:vt6656:baseband.h: fix function definition argument without identifier name issue Mikhail Golubev <golubev.mikhail@gmail.com> - 2016-10-14 11:10 +0200

csiph-web