Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499835

[PATCH] mfd: intel-lpss: Do not put device in reset state on suspend

Show all headers | View raw

Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
suspend") saved the register context while going to suspend and
also put the device in reset state.

Due to the resetting of device, system cannot enter S3/S0ix
states when no_console_suspend flag is enabled. The system
and serial console both hang. The resetting of device is not
needed while going to suspend. Hence remove this code.

Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
 drivers/mfd/intel-lpss.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 41b1138..70c646b 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev)
 	for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
 		lpss->priv_ctx[i] = readl(lpss->priv + i * 4);
 
-	/* Put the device into reset state */
-	writel(0, lpss->priv + LPSS_PRIV_RESETS);
-
 	return 0;
 }
 EXPORT_SYMBOL_GPL(intel_lpss_suspend);
-- 
2.10.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: intel-lpss: Do not put device in reset state on suspend Azhar Shaikh <azhar.shaikh@intel.com> - 2016-10-12 19:20 +0200
  Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on  suspend Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-12 19:30 +0200
  Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on  suspend Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-10-13 09:30 +0200
  Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on  suspend Lee Jones <lee.jones@linaro.org> - 2016-10-26 14:30 +0200

csiph-web