Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1499828

Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()

From Benjamin Tissoires <benjamin.tissoires@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()
Date 2016-10-12 19:00 +0200
Message-ID <srv2O-73S-23@gated-at.bofh.it> (permalink)
References <sruT7-70w-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> From: David Arcari <darcari@redhat.com>
>
> acpi_dev_gpio_irq_get() currently ignores the error returned
> by acpi_get_gpiod_by_index() and overwrites it with -ENOENT.
>
> Problem is this error can be -EPROBE_DEFER, which just blows
> up some drivers when the module ordering is not correct.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: David Arcari <darcari@redhat.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi David,
>
> I am planning on sending this to the list, any last minute comments?

Of course, I forgot to remove our internal sync comment.
David's answer was "No.  This looks good to me.", so I just went ahead
and send the patch.

Cheers,
Benjamin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-10-12 18:50 +0200
  Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() Benjamin Tissoires <benjamin.tissoires@gmail.com> - 2016-10-12 19:00 +0200
  Re: [PATCH] gpio / ACPI: fix returned error from  acpi_dev_gpio_irq_get() Mika Westerberg <mika.westerberg@intel.com> - 2016-10-13 09:20 +0200
  Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() Linus Walleij <linus.walleij@linaro.org> - 2016-10-20 14:20 +0200

csiph-web