[PATCH 3.4 106/125] ipv6/addrlabel: fix ip6addrlbl_get()

From	lizf@kernel.org
Newsgroups	linux.kernel
Subject	[PATCH 3.4 106/125] ipv6/addrlabel: fix ip6addrlbl_get()
Date	2016-10-12 15:10 +0200
Message-ID	<srrse-4OM-67@gated-at.bofh.it> (permalink)
References	<srqZb-4nM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Andrey Ryabinin <aryabinin@virtuozzo.com>

3.4.113-rc1 review patch.  If anyone has any objections, please let me know.

------------------


commit e459dfeeb64008b2d23bdf600f03b3605dbb8152 upstream.

ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded,
ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed,
ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer.

Fix this by inverting ip6addrlbl_hold() check.

Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reviewed-by: Cong Wang <cwang@twopensource.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
 net/ipv6/addrlabel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/addrlabel.c b/net/ipv6/addrlabel.c
index 2d8ddba..c8c6a12 100644
--- a/net/ipv6/addrlabel.c
+++ b/net/ipv6/addrlabel.c
@@ -558,7 +558,7 @@ static int ip6addrlbl_get(struct sk_buff *in_skb, struct nlmsghdr* nlh,
 
 	rcu_read_lock();
 	p = __ipv6_addr_label(net, addr, ipv6_addr_type(addr), ifal->ifal_index);
-	if (p && ip6addrlbl_hold(p))
+	if (p && !ip6addrlbl_hold(p))
 		p = NULL;
 	lseq = ip6addrlbl_table.seq;
 	rcu_read_unlock();
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.4 106/125] ipv6/addrlabel: fix ip6addrlbl_get() lizf@kernel.org - 2016-10-12 15:10 +0200

csiph-web