Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499672

[PATCH v2 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone()

Show all headers | View raw

Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that
ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/scsi/libfc/fc_lport.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
index 156708a..53d13721 100644
--- a/drivers/scsi/libfc/fc_lport.c
+++ b/drivers/scsi/libfc/fc_lport.c
@@ -1911,7 +1911,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp,
 		bsg_reply->result = (PTR_ERR(fp) == -FC_EX_CLOSED) ?
 			-ECONNABORTED : -ETIMEDOUT;
 		job->reply_len = sizeof(uint32_t);
-		job->state_flags |= FC_RQST_STATE_DONE;
 		fc_bsg_jobdone(job, bsg_reply->result,
 			       bsg_reply->reply_payload_rcv_len);
 		kfree(info);
@@ -1947,7 +1946,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp,
 			bsg_reply->reply_payload_rcv_len =
 				job->reply_payload.payload_len;
 		bsg_reply->result = 0;
-		job->state_flags |= FC_RQST_STATE_DONE;
 		fc_bsg_jobdone(job, bsg_reply->result,
 			       bsg_reply->reply_payload_rcv_len);
 		kfree(info);
-- 
1.8.5.6

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/16] Convert FibreChannel bsg code to use bsg-lib Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:10 +0200
  [PATCH v2 11/16] scsi: fc: Use bsg_destroy_job Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  [PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
    Re: [PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC  drivers Hannes Reinecke <hare@suse.de> - 2016-10-13 13:30 +0200
  [PATCH v2 08/16] scsi: fc: implement kref backed reference counting Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
    Re: [PATCH v2 08/16] scsi: fc: implement kref backed reference  counting Hannes Reinecke <hare@suse.de> - 2016-10-13 13:50 +0200
      Re: [PATCH v2 08/16] scsi: fc: implement kref backed reference  counting Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-13 16:50 +0200
  [PATCH v2 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  [PATCH v2 06/16] scsi: fc: provide fc_bsg_to_rport() helper Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  [PATCH v2 09/16] block: add reference counting for struct bsg_job Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  [PATCH v2 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  [PATCH v2 05/16] scsi: fc: provide fc_bsg_to_shost() helper Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-12 15:20 +0200
  Re: [PATCH v2 00/16] Convert FibreChannel bsg code to use bsg-lib Steffen Maier <maier@linux.vnet.ibm.com> - 2016-10-12 21:50 +0200
    Re: [PATCH v2 00/16] Convert FibreChannel bsg code to use bsg-lib Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-13 10:30 +0200
  Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and  fc_bsg_job::reply directly Hannes Reinecke <hare@suse.de> - 2016-10-13 13:30 +0200
  Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and  fc_bsg_job::reply directly Steffen Maier <maier@linux.vnet.ibm.com> - 2016-10-13 17:20 +0200
    Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and  fc_bsg_job::reply directly Johannes Thumshirn <jthumshirn@suse.de> - 2016-10-13 18:30 +0200

csiph-web