[PATCH 3.4 089/125] spi: fix parent-device reference leak

From	lizf@kernel.org
Newsgroups	linux.kernel
Subject	[PATCH 3.4 089/125] spi: fix parent-device reference leak
Date	2016-10-12 14:50 +0200
Message-ID	<srr8S-4rr-23@gated-at.bofh.it> (permalink)
References	<srqZb-4nM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Johan Hovold <johan@kernel.org>

3.4.113-rc1 review patch.  If anyone has any objections, please let me know.

------------------


commit 157f38f993919b648187ba341bfb05d0e91ad2f6 upstream.

Fix parent-device reference leak due to SPI-core taking an unnecessary
reference to the parent when allocating the master structure, a
reference that was never released.

Note that driver core takes its own reference to the parent when the
master device is registered.

Fixes: 49dce689ad4e ("spi doesn't need class_device")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index a3f31e9..516fd23 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -846,7 +846,7 @@ struct spi_master *spi_alloc_master(struct device *dev, unsigned size)
 
 	device_initialize(&master->dev);
 	master->dev.class = &spi_master_class;
-	master->dev.parent = get_device(dev);
+	master->dev.parent = dev;
 	spi_master_set_devdata(master, &master[1]);
 
 	return master;
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.4 089/125] spi: fix parent-device reference leak lizf@kernel.org - 2016-10-12 14:50 +0200

csiph-web