Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499518
| From | lizf@kernel.org |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3.4 007/125] recordmcount: Fix endianness handling bug for nop_mcount |
| Date | 2016-10-12 14:40 +0200 |
| Message-ID | <srqZb-4nM-9@gated-at.bofh.it> (permalink) |
| References | <srqZb-4nM-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: libin <huawei.libin@huawei.com>
3.4.113-rc1 review patch. If anyone has any objections, please let me know.
------------------
commit c84da8b9ad3761eef43811181c7e896e9834b26b upstream.
In nop_mcount, shdr->sh_offset and welp->r_offset should handle
endianness properly, otherwise it will trigger Segmentation fault
if the recordmcount main and file.o have different endianness.
Link: http://lkml.kernel.org/r/563806C7.7070606@huawei.com
Signed-off-by: Li Bin <huawei.libin@huawei.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
scripts/recordmcount.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 5e29610..799d734 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -375,7 +375,7 @@ static void nop_mcount(Elf_Shdr const *const relhdr,
if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
if (make_nop)
- ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset);
+ ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
if (warn_on_notrace_sect && !once) {
printf("Section %s has mcount callers being ignored\n",
txtname);
--
1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 3.4 007/125] recordmcount: Fix endianness handling bug for nop_mcount lizf@kernel.org - 2016-10-12 14:40 +0200
Re: [PATCH 3.4 007/125] recordmcount: Fix endianness handling bug for nop_mcount Steven Rostedt <rostedt@goodmis.org> - 2016-10-12 15:20 +0200
Re: [PATCH 3.4 007/125] recordmcount: Fix endianness handling bug for nop_mcount Zefan Li <lizefan@huawei.com> - 2016-10-13 03:10 +0200
csiph-web