Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499478
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Catalin Marinas <catalin.marinas@arm.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning |
| Date | Wed, 12 Oct 2016 12:50:01 +0200 |
| Message-ID | <srpgJ-3eb-7@gated-at.bofh.it> (permalink) |
| References | <sroum-2vS-11@gated-at.bofh.it> <sroXo-372-7@gated-at.bofh.it> |
| X-Original-To | Hillf Danton <hillf.zj@alibaba-inc.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 13 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-mm@kvack.org, linux-kernel@vger.kernel.org, 'Andrew Morton' <akpm@linux-foundation.org>, 'Andy Lutomirski' <luto@kernel.org>, 'CAI Qian' <caiqian@redhat.com> |
| X-Original-Date | Wed, 12 Oct 2016 11:47:58 +0100 |
| X-Original-Message-ID | <20161012104758.GB21592@e104818-lin.cambridge.arm.com> |
| X-Original-References | <1476266223-14325-1-git-send-email-catalin.marinas@arm.com> <00ca01d22471$bcef4ef0$36cdecd0$@alibaba-inc.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1499478 |
Show key headers only | View raw
On Wed, Oct 12, 2016 at 06:16:46PM +0800, Hillf Danton wrote:
> > @@ -1453,8 +1453,11 @@ static void kmemleak_scan(void)
> >
> > read_lock(&tasklist_lock);
> > do_each_thread(g, p) {
>
> Take a look at this commit please.
> 1da4db0cd5 ("oom_kill: change oom_kill.c to use for_each_thread()")
Thanks. Isn't holding tasklist_lock here enough to avoid such races?
--
Catalin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning Catalin Marinas <catalin.marinas@arm.com> - 2016-10-12 12:00 +0200
Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-10-12 12:30 +0200
Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning Catalin Marinas <catalin.marinas@arm.com> - 2016-10-12 12:50 +0200
Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning Michal Hocko <mhocko@kernel.org> - 2016-10-12 12:50 +0200
Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning Catalin Marinas <catalin.marinas@arm.com> - 2016-10-12 18:20 +0200
Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning CAI Qian <caiqian@redhat.com> - 2016-10-12 18:40 +0200
csiph-web