Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h
Date	2016-10-12 12:30 +0200
Message-ID	<sroXo-372-29@gated-at.bofh.it> (permalink)
References	<srlGa-Ku-9@gated-at.bofh.it> <srlGa-Ku-19@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2016-10-12 at 14:51 +0800, Tan Jui Nee wrote:
> Move the enum's definition into a standalone header file which can be
> used
> wherever its definition is needed.
> 
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -43,4 +43,75 @@ struct lpc_ich_info {
>  	u8 use_gpio;
>  };
>  
> +/* chipset related info */
> +enum lpc_chipsets {

Maybe it worth to add that the list should be not shuffled, new items
should go at the end.

But it is up to you.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h Tan Jui Nee <jui.nee.tan@intel.com> - 2016-10-12 09:00 +0200
  Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-12 12:30 +0200

csiph-web