Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] cpufreq: pxa: convert to clock API
Date	2016-10-12 10:30 +0200
Message-ID	<srn5f-1KJ-7@gated-at.bofh.it> (permalink)
References	<sqP3A-5Ds-7@gated-at.bofh.it> <sqPdg-5GQ-13@gated-at.bofh.it> <srhCx-6C9-1@gated-at.bofh.it> <srld7-zR-13@gated-at.bofh.it> <srlmN-Dw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Viresh Kumar <viresh.kumar@linaro.org> writes:

> On 12-10-16, 08:22, Robert Jarzmik wrote:
>> Viresh Kumar <viresh.kumar@linaro.org> writes:
>> 
>> > On 10-10-16, 22:09, Robert Jarzmik wrote:
>> >> As the clock settings have been introduced into the clock pxa drivers,
>> >> which are now available to change the CPU clock by themselves, remove
>> >> the clock handling from this driver, and rely on pxa clock drivers.
>> >> 
>> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> >> ---
>> >>  drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++-------------------------------
>> >>  1 file changed, 39 insertions(+), 152 deletions(-)
>> >
>> > As you mentioned in the previous patch, why can't you use cpufreq-dt
>> > driver now and delete this one ?
>> 
>> PXA architecture have both legacy platform_data based configurations and new
>> devicetree based ones.
>
> I don't see any platform data specific code in this driver. What am I
> missing ?

In a legacy platform, ie. without devicetree, we have CONFIG_OF=n.
How would cpufreq-dt be usable in this case ?

You can see such a platform in arch/arm/configs/mainstone_defconfig and
arch/arm/mach-pxa/mainstone.c as an example.

Cheers.

-- 
Robert

Thread

[PATCH 0/6] Make pxa core clocks settable Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:10 +0200
  [PATCH 3/6] clk: pxa: b bit of clkcfg means fast bus Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200
  [PATCH 6/6] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200
    Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 04:40 +0200
      Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-12 08:30 +0200
        Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 08:40 +0200
          Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-12 10:30 +0200
            Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 10:50 +0200
              Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-12 21:20 +0200
  [PATCH 1/6] clk: pxa: remove unused variables Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200
  [PATCH 2/6] clk: pxa: core pll is not affected by t bit Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200
  [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200
  [PATCH 4/6] clk: pxa: export core clocks Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-10 22:20 +0200

csiph-web