Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499368

Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue

Show all headers | View raw

On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces to else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
>  drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index d8bf859..376e17c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
>                 num = gb_audio_manager_dump_module(id);
>                 if (num)
>                         return num;
> -       } else if (!strncmp("all", buf, 3))
> +       } else if (!strncmp("all", buf, 3)) {
>                 gb_audio_manager_dump_all();
> -       else
> +       } else {
>                 return -EINVAL;
> +       }
>
>         return count;
>  }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue Chase Metzger <chasemetzger15@gmail.com> - 2016-10-12 01:30 +0200
  Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed  CHECK for brace issue Vaibhav Agarwal <vaibhav.sr@gmail.com> - 2016-10-12 08:10 +0200

csiph-web