Re: [PATCH] strparser: Propagate correct error code in strp_recv()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] strparser: Propagate correct error code in strp_recv()
Date	2016-10-12 08:10 +0200
Message-ID	<srkTL-ql-11@gated-at.bofh.it> (permalink)
References	<sphdE-Kt-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  6 Oct 2016 15:41:49 +0200

> With m68k-linux-gnu-gcc-4.1:
> 
>     net/strparser/strparser.c: In function ‘strp_recv’:
>     net/strparser/strparser.c:98: warning: ‘err’ may be used uninitialized in this function
> 
> Pass "len" (which is an error code when negative) instead of the
> uninitialized "err" variable to fix this.
> 
> Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied and queued up for -stable, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] strparser: Propagate correct error code in strp_recv() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 15:50 +0200
  Re: [PATCH] strparser: Propagate correct error code in strp_recv() David Miller <davem@davemloft.net> - 2016-10-12 08:10 +0200

csiph-web