Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi

From	Hanjun Guo <guohanjun@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi
Date	2016-10-12 04:10 +0200
Message-ID	<srh9v-6ic-9@gated-at.bofh.it> (permalink)
References	<srgwN-5Oo-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/10/12 9:20, MaJun wrote:
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
>
> Signed-off-by: MaJun <majun258@huawei.com>
> ---
>  drivers/acpi/resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 56241eb..9918326 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
>  
>  	res->flags = acpi_dev_irq_flags(triggering, polarity, shareable);
>  	irq = acpi_register_gsi(NULL, gsi, triggering, polarity);
> -	if (irq >= 0) {
> +	if (irq > 0) {

On x86 or IA64, irq 0 is a valid irq number as far as I know.

Thanks
Hanjun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi MaJun <majun258@huawei.com> - 2016-10-12 03:30 +0200
  Re: [PATCH] ACPI: fix the process flow for 0 which return from  acpi_register_gsi Hanjun Guo <guohanjun@huawei.com> - 2016-10-12 04:10 +0200

csiph-web