Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1499203

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change
Date 2016-10-11 23:00 +0200
Message-ID <srcjw-30Y-9@gated-at.bofh.it> (permalink)
References <spKIG-69y-17@gated-at.bofh.it> <spKIH-69y-49@gated-at.bofh.it> <sqEKS-7N2-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> Andrew, are you happy with this implementation?

Sorry, been to busy with other things to follow the discussion.

What would be nice to see is a comment about how the link to LEDs in
the PHYs is made. Often there is a couple of LEDs in the RJ45 socket
driven by the PHY. They can show link, speed, packet Rx/Tx, etc. How
are these triggers related to these LEDs?

    Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] Add support for led triggers on phy link state change Zach Brown <zach.brown@ni.com> - 2016-10-07 23:20 +0200
  [RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown <zach.brown@ni.com> - 2016-10-07 23:20 +0200
  [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change Zach Brown <zach.brown@ni.com> - 2016-10-07 23:20 +0200
    Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link  state change Florian Fainelli <f.fainelli@gmail.com> - 2016-10-10 11:10 +0200
      Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link  state change Andrew Lunn <andrew@lunn.ch> - 2016-10-11 23:00 +0200

csiph-web