Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499148
| From | Helge Deller <deller@gmx.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: parisc crash on boot with 4.8+git |
| Date | 2016-10-11 20:50 +0200 |
| Message-ID | <srahI-1Pi-41@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <sqs6Z-8ji-13@gated-at.bofh.it> <sqsql-8pN-7@gated-at.bofh.it> <sqAxz-56F-3@gated-at.bofh.it> <sqK3U-2rp-5@gated-at.bofh.it> <sqKdz-2uP-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Meelis Roos <mroos@linux.ee>:
> > > Memory Ranges:
> > > 0) Start 0x0000000000000000 End 0x000000003fffffff Size 1024 MB
> > > 1) Start 0x0000004040000000 End 0x000000407fdfffff Size 1022 MB
> > > Total Memory: 2046 MB
Meelis and myself debugged the crash off-list.
It turns out, that I missed to zero-initialize the new memblocks.
Patch below fixes this.
Helge
------------
parisc: Zero-initialize newly alloced memblock
Commit 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
switched to the memblock allocator, but missed to zero-initialize the
newly allocated memblocks. This lead to crashes on some machines like
the rp3410.
Fixes: 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
index 356f384..62ac801 100644
--- a/arch/parisc/mm/init.c
+++ b/arch/parisc/mm/init.c
@@ -105,6 +105,8 @@ static void * __init get_memblock(unsigned long size)
else
panic("get_memblock() failed.\n");
+ memset(__va(phys), 0, size);
+
return __va(phys);
}
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-08 22:30 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-08 23:10 +0200
Re: parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-09 09:40 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-09 11:10 +0200
Re: parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-09 21:40 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-09 22:00 +0200
Re: parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-10 06:40 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-10 16:50 +0200
Re: parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-10 17:00 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-11 20:50 +0200
Re: parisc crash on boot with 4.8+git John David Anglin <dave.anglin@bell.net> - 2016-10-09 16:10 +0200
Re: parisc crash on boot with 4.8+git Meelis Roos <mroos@linux.ee> - 2016-10-09 21:50 +0200
Re: parisc crash on boot with 4.8+git Helge Deller <deller@gmx.de> - 2016-10-09 22:00 +0200
csiph-web