Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm
Date	2016-10-14 01:40 +0200
Message-ID	<srXLs-1KS-45@gated-at.bofh.it> (permalink)
References	<sr4Fj-6Lx-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Zijun.

On Tue, Oct 11, 2016 at 08:48:45PM +0800, zijun_hu wrote:
> compared with the original algorithm theoretically and practically, the
> new one educes the same grouping results, besides, it is more effective,
> simpler and easier to understand.

If the original code wasn't broken and the new code produces the same
output, I'd really not mess with this code.  There simply is no upside
to messing with this code.  It's run once during boot and never a
noticeable contributor of boot overhead.  Maybe the new code is a bit
simpler and more efficient but the actual benefit is so small that any
risk would outweigh it.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm Tejun Heo <tj@kernel.org> - 2016-10-14 01:40 +0200
  Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm zijun_hu <zijun_hu@zoho.com> - 2016-10-14 02:00 +0200
    Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm Tejun Heo <tj@kernel.org> - 2016-10-14 02:40 +0200
      Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm zijun_hu <zijun_hu@zoho.com> - 2016-10-14 03:20 +0200

csiph-web