[PATCH] vt: clear selection before resizing

From	Scot Doyle <lkml14@scotdoyle.com>
Newsgroups	linux.kernel
Subject	[PATCH] vt: clear selection before resizing
Date	2016-10-13 19:20 +0200
Message-ID	<srRPH-6uS-17@gated-at.bofh.it> (permalink)
References	<sdoNz-Sw-7@gated-at.bofh.it> <spJCX-5r1-47@gated-at.bofh.it> <sre1Y-4bi-7@gated-at.bofh.it> <srM3E-2I3-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When resizing a vt its selection may exceed the new size, resulting in
an invalid memory access [1]. Clear the selection before resizing.

[1] http://lkml.kernel.org/r/CACT4Y+acDTwy4umEvf5ROBGiRJNrxHN4Cn5szCXE5Jw-d1B=Xw@mail.gmail.com

Reported-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
---
 drivers/tty/vt/vt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 06fb39c..5d6a549 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -874,6 +874,9 @@ static int vc_do_resize(struct tty_struct *tty, struct vc_data *vc,
 	if (!newscreen)
 		return -ENOMEM;
 
+	if (vc == sel_cons)
+		clear_selection();
+
 	old_rows = vc->vc_rows;
 	old_row_size = vc->vc_size_row;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: tty, fbcon: use-after-free in fbcon_invert_region Dmitry Vyukov <dvyukov@google.com> - 2016-10-07 22:10 +0200
  Re: tty, fbcon: use-after-free in fbcon_invert_region Scot Doyle <lkml14@scotdoyle.com> - 2016-10-11 04:00 +0200
    Re: tty, fbcon: use-after-free in fbcon_invert_region Dmitry Vyukov <dvyukov@google.com> - 2016-10-11 15:40 +0200
  Re: tty, fbcon: use-after-free in fbcon_invert_region Scot Doyle <lkml14@scotdoyle.com> - 2016-10-12 00:50 +0200
    Re: tty, fbcon: use-after-free in fbcon_invert_region Dmitry Vyukov <dvyukov@google.com> - 2016-10-13 13:10 +0200
      [PATCH] vt: clear selection before resizing Scot Doyle <lkml14@scotdoyle.com> - 2016-10-13 19:20 +0200

csiph-web