Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500301

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

Show all headers | View raw

Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

Thanks,
   Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> 	ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> 				   handle_level_irq, IRQ_TYPE_NONE);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add irq chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> 		goto exit_line_free;
> 	}
>
> 	ret = gpiochip_add(gpio);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add gpio chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> 		goto exit_gpio_irqchip_remove;
> 	}
>
>-- 
>2.7.1.410.g6faf27b
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-12 04:50 +0200
  Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead  of bundle->dev Rui Miguel Silva <rmfrfs@gmail.com> - 2016-10-13 16:30 +0200
  Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead  of bundle->dev Johan Hovold <johan@kernel.org> - 2016-10-15 13:20 +0200

csiph-web