[PATCH] ceph: Fix uninitialized dentry pointer in ceph_real_mount()

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	[PATCH] ceph: Fix uninitialized dentry pointer in ceph_real_mount()
Date	2016-10-13 17:20 +0200
Message-ID	<srPXB-5cV-41@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

    fs/ceph/super.c: In function ‘ceph_real_mount’:
    fs/ceph/super.c:818: warning: ‘root’ may be used uninitialized in this function

If s_root is already valid, dentry pointer root is never initialized,
and returned by ceph_real_mount(). This will cause a crash later when
the caller dereferences the pointer.

Fix this by initializing root early.

Fixes: ce2728aaa82bbeba ("ceph: avoid accessing / when mounting a subpath")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Compile-tested only.
---
 fs/ceph/super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index a29ffce981879d5f..794c5fd0e0cf5e45 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -821,7 +821,8 @@ static struct dentry *ceph_real_mount(struct ceph_fs_client *fsc)
 	dout("mount start %p\n", fsc);
 	mutex_lock(&fsc->client->mount_mutex);
 
-	if (!fsc->sb->s_root) {
+	root = fsc->sb->s_root;
+	if (!root) {
 		const char *path;
 		err = __ceph_open_session(fsc->client, started);
 		if (err < 0)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ceph: Fix uninitialized dentry pointer in ceph_real_mount() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-13 17:20 +0200
  Re: [PATCH] ceph: Fix uninitialized dentry pointer in ceph_real_mount() "Yan, Zheng" <ukernel@gmail.com> - 2016-10-14 04:50 +0200
    Re: [PATCH] ceph: Fix uninitialized dentry pointer in ceph_real_mount() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-17 09:50 +0200

csiph-web