Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt
Date	2016-10-13 14:30 +0200
Message-ID	<srNj3-3tk-11@gated-at.bofh.it> (permalink)
References	<shylj-3ql-17@gated-at.bofh.it> <shAQ9-54k-5@gated-at.bofh.it> <sj1XX-2Zs-1@gated-at.bofh.it> <srpA6-3Ax-15@gated-at.bofh.it> <srrLA-4Wx-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-10-12 21:17 GMT+08:00 Thomas Gleixner <tglx@linutronix.de>:
> On Wed, 12 Oct 2016, Wanpeng Li wrote:
>> irq_enter() which is called in scheduler_ipi() is too late to tell RCU
>> susbstems to end the extended quiescent state before ack_APIC_irq(),
>> any ideas?
>
> You can call irq_enter/exit() in __smp_reschedule_interrupt(). It can be
> called nested.

In smp_reschedule_interrupt()? Do you mean something like this?

diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 658777c..ac2ee87 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -259,8 +259,10 @@ static inline void __smp_reschedule_interrupt(void)

 __visible void smp_reschedule_interrupt(struct pt_regs *regs)
 {
+       irq_enter();
        ack_APIC_irq();
        __smp_reschedule_interrupt();
+       irq_exit();
        /*
         * KVM uses this interrupt to force a cpu out of guest mode
         */

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt Wanpeng Li <kernellwp@gmail.com> - 2016-10-12 13:10 +0200
  Re: [PATCH] x86/apic: Fix suspicious RCU usage in  smp_trace_call_function_interrupt Thomas Gleixner <tglx@linutronix.de> - 2016-10-12 15:30 +0200
    Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt Wanpeng Li <kernellwp@gmail.com> - 2016-10-13 14:30 +0200

csiph-web